fix #50926: add setting and option for MP3 bitrate #2993
Conversation
Jojo-Schmitz
force-pushed
the
mp3-export
branch
from
47f0726
to
5721e16
Compare
| @@ -201,7 +199,8 @@ void Preferences::init() | |||
| #else | |||
| nativeDialogs = false; // don't use system native file dialogs | |||
| #endif | |||
| exportAudioSampleRate = exportAudioSampleRates[0]; | |||
| exportAudioSampleRate = 44100; | |||
There was a problem hiding this comment.
what's wrong with exportAudioSampleRates[0] ?
There was a problem hiding this comment.
I deleted it, it was superfluos and duplicated from the pull down menu
There was a problem hiding this comment.
not as superfluos as I though though...
mscore/preferences.cpp
Outdated
| @@ -501,14 +501,15 @@ void Preferences::read() | |||
| dir.mkpath(myImagesPath); | |||
| dir.mkpath(myTemplatesPath); | |||
| dir.mkpath(myPluginsPath); | |||
| foreach (QString path, mySoundfontsPath.split(";")) | |||
| for (QString path: mySoundfontsPath.split(";")) | |||
There was a problem hiding this comment.
you miss a space here before :
I'm pretty sure all these space modification will not apply to 2.1
There was a problem hiding this comment.
OK, got rid of those, for now
mscore/preferences.cpp
Outdated
| @@ -720,7 +716,7 @@ void PreferenceDialog::hideEvent(QHideEvent* ev) | |||
|
|
|||
| void PreferenceDialog::recordButtonClicked(int val) | |||
| { | |||
| foreach(QAbstractButton* b, recordButtons->buttons()) { | |||
| for (QAbstractButton* b: recordButtons->buttons()) { | |||
mscore/preferences.cpp
Outdated
| @@ -882,7 +878,7 @@ void PreferenceDialog::updateValues() | |||
| // | |||
| qDeleteAll(localShortcuts); | |||
| localShortcuts.clear(); | |||
| foreach(const Shortcut* s, Shortcut::shortcuts()) | |||
| for (const Shortcut* s: Shortcut::shortcuts()) | |||
mscore/preferences.cpp
Outdated
| if (idx == n) // if not found in table | ||
| idx = 0; | ||
| exportAudioSampleRate->setCurrentIndex(idx); | ||
| index = exportAudioSampleRate->findText(QString("%1").arg(prefs.exportAudioSampleRate)); |
There was a problem hiding this comment.
You need to make sure that the text is not translated, or better set Data and use findData
There was a problem hiding this comment.
I'm affraid I don't get it. It uses the same method as alsaSampleRate and alsaPeriodSize use too.
There was a problem hiding this comment.
I will have another look but I guess these two need to be changed as well. If we save the text from the combo box in prefs.exportAudioSampleRate it will be translated. If the translation is different and the user changes his language, then when reading it back it will not work well. That's why other part of the code use the userData of the combobox item and not the text.
There was a problem hiding this comment.
You're most probably right, I wondered too about translation effects.
There was a problem hiding this comment.
Hmm, seems I can't get it to work :-(
There was a problem hiding this comment.
Seems to work now
Jojo-Schmitz
force-pushed
the
mp3-export
branch
3 times, most recently
from
7008773
to
fbcb7bd
Compare
and some code and UI cleanup
Jojo-Schmitz
force-pushed
the
mp3-export
branch
from
fbcb7bd
to
6a3f31f
Compare
|
Can we get this into 2.1 too? |
|
sure, consider it done. |
and some code (style) and UI cleanup
We may want this in master and 2.1. Not sure it'd apply cleanly to 2.1, but am willing to create a separate PR for that purpose if need be.
Adjusting the handbook would need to be done too, in at least 3 places (Preferences, including a new picture, File formats/MP3 Export and Command line options)